Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting midway through slide with id "story-youth", section placement vs. hash navigation gets out sync #103

Open
bepetersn opened this issue Oct 8, 2014 · 6 comments
Open

Starting midway through slide with id "story-youth", section placement vs. hash navigation gets out sync #103

bepetersn opened this issue Oct 8, 2014 · 6 comments
Assignees
@bepetersn
Labels
bug

Comments

@bepetersn
Copy link
Member

No description provided.

@bepetersn bepetersn changed the title Starting midway through slide with id "story-youth", section placement vs. hash navigation get out sync Starting midway through slide with id "story-youth", section placement vs. hash navigation gets out sync Oct 8, 2014
@bepetersn
Copy link
Member Author

I'm having a hard time figuring this out. It could be something with scrollspy, ... or ... something else. I don't know. Can you see this behavior, @ghing?

@bepetersn bepetersn self-assigned this Oct 8, 2014
@bepetersn
Copy link
Member Author

This applies specifically to my hash-change-visits-top-of-element branch, where it starts getting out of sync with story-youth. But before that, it was just getting progressively more out of sync the whole time.

It's probably something to do with the margin / height I added for that change.

@bepetersn bepetersn added the bug label Oct 8, 2014
@ghing
Copy link
Contributor

ghing commented Oct 13, 2014

I'm seeing this. I'll look into it.

ghing added a commit that referenced this issue Oct 14, 2014
@ghing
Refresh scrollspy when (re)rendering charts
fa97a3f 
The navigation update, which relies on scrollspy events, was
getting wonky after chart-heavy sections.  This is because you
need to call ``$selection.scrollspy('refresh')`` when adding
or removing elements from the DOM.

See http://getbootstrap.com/javascript/#scrollspy

Addresses #103
@ghing
Copy link
Contributor

ghing commented Oct 14, 2014

@bepetersn, can you check and see if fa97a3f fixes this for you?

@bepetersn
Copy link
Member Author

Does it fix it for you? I'm seeing the same behavior still.

@ghing
Copy link
Contributor

ghing commented Oct 14, 2014

It does. Can you do a hard refresh and document expected/observed behavior if you're still seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bepetersn bepetersn

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghing @bepetersn