You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently sbt.internal.inc.AnalyzingCompiler holds a bunch of scala compiler related jars in its ClassLoaderCache.
While build tools can just call AnalyzingCompiler.classLoaderCache.map(_.close()) to release the jars, I am thinking if it would be better for AnalyzingCompiler to be Closeable, so build tools using Zinc can just call AnalyzingCompiler.close() and every resource that the Zinc compiler instance is holding is then closed.
Also making AnalyzingCompilerClosable makes it more obvious that Zinc holds certain resources, and once the build tool no longer need to use the compiler, the resources needs to be released.
The text was updated successfully, but these errors were encountered:
Friendseeker
changed the title
Should sbt.internal.inc.AnalyzingCompiler be closeable?
Should sbt.internal.inc.AnalyzingCompiler be Closeable?
Oct 17, 2024
Currently
sbt.internal.inc.AnalyzingCompiler
holds a bunch of scala compiler related jars in itsClassLoaderCache
.While build tools can just call
AnalyzingCompiler.classLoaderCache.map(_.close())
to release the jars, I am thinking if it would be better forAnalyzingCompiler
to beCloseable
, so build tools using Zinc can just callAnalyzingCompiler.close()
and every resource that the Zinc compiler instance is holding is then closed.Also making
AnalyzingCompiler
Closable
makes it more obvious that Zinc holds certain resources, and once the build tool no longer need to use the compiler, the resources needs to be released.The text was updated successfully, but these errors were encountered: