-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the library to [lib]combine #47
Comments
The problem that i see, is with this change, all packages that ever used libCombine will have to change. So far they would have had a fallback statement using the
|
Fair enough. I have my own fork of the library, so I am fine. (Feel free to close this issue and the corresponding PR.) |
With
[lib]Combine
, a CMake file called[lib]Combine-static-config.cmake
gets generated. Such a CMake file cannot be found on a case-sensitive system (since that kind of filename should be all lower case). Instead, a CMake file called[lib]combine-static-config.cmake
should be generated, hence the suggestion to rename the library to[lib]combine
, not least so that it's consistent with libSBML, for instance.The text was updated successfully, but these errors were encountered: