Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas.openapi.SchemaGenerator.get_schema request argument should be optional #41

Open
dolfandringa opened this issue Jul 26, 2023 · 0 comments

Comments

@dolfandringa
Copy link

The schemas.openapi.SchemaGenerator.get_schema request argument is optional in drf. If you override the clause, it either results in pyright complaining that we incorrectly override the method if we set the type of request: Request|None since the type is now different, or if we say request: Request = None of course it will show a type error, and if we leave out the default value, now we make it mandatory, while it shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant