Liquidsoap 2.2.x - harbor.http.register broken

[danbo]

Describe the bug
Logic in my harbor handler is causing liquidsoap to error out during registration. This worked in 2.1.4

To Reproduce

1a - Currently working per example in 2.2.x

radio = ref(blank())

def skip(request, response) =
  radio().skip()
  response.data("Skipped!")
end

harbor.http.register(port=26342, method="GET", "/skip", skip)

1b - Not working in 2.2.x but was working in 2.1.4 (with slightly different query parsing)

req= request.queue(id="user_request")

def requestTrack(request, response) =
  url = request.query["url"]
  req.push(request.create(trackUrl))
  response.data("Request successful")
end

harbor.http.register(port=26342, method="GET", "/request/:url", requestTrack)

Error

At /myscript.liq, line 203, char 74-86:
harbor.http.register(port=26342, method="GET", "/request/:url", requestTrack)

Error 5: this value has type
  (_.{create : _, query : _}, ...) -> _ (inferred at /myscript.liq, line 172 char 0 - line 177 char 3)
but it should be a subtype of the type of the value at /usr/share/liquidsoap-lang/libs/http.liq, line 391, char 71-78
  (
   {
     body : (?timeout : float) -> string,
     data : (?timeout : float) -> string,
     headers : [string * string],
     http_version : string,
     method : string,
     path : string,
     query : _
   }, ...) -> _ (inferred at /usr/share/liquidsoap-lang/libs/http.liq, line 364, char 45-53)

Once req is removed from the handler, the liq script starts as expected.

Same for another registration / handler - the example on how to flush and skip

my_source = request.dynamic(...)

def flushAndSkip(request, response) =
  s = my_source
  q = s.queue()
  s.set_queue([])
  s.skip()
  list.iter(request.destroy, q)
  response.data("The queue was flushed!")
end

Error:

At /myscript.liq, line 202, char 64-76:
harbor.http.register(port=26342, method="GET", "/flushAndSkip", flushAndSkip)

Error 5: this value has type
  (_.{destroy : _}, ...) -> _ (inferred at /myscript.liq, line 160 char 0 - line 168 char 3)
but it should be a subtype of the type of the value at /usr/share/liquidsoap-lang/libs/http.liq, line 391, char 71-78
  (
   {
     body : (?timeout : float) -> string,
     data : (?timeout : float) -> string,
     headers : [string * string],
     http_version : string,
     method : string,
     path : string,
     query : [string * string]
   }, ...) -> _ (inferred at /usr/share/liquidsoap-lang/libs/http.liq, line 364, char 45-53)

1c - In fact, even simple registration without the req throws an error

#req = request.queue(id="live")
def requestTrack2(request) =
  url = request.query["url"]
  #req.push(request.create(url))
  harbor.http.response(
    content_type="text/html",
    data="<p>Made request</p>"
  )  
end

harbor.http.register.simple(port=26342, method="GET", "/request/:track", requestTrack2)

Error:

At /myscript.liq, line 183, char 2-13:
  harbor.http.response(

Error 5: this value has no method `response`
  Its type is
{
  middleware :
  {
    cors : 'a.'b.'c.'d.(?origin : string?,
 ... <really long definition>

Expected behavior
Liquidsoap should not be throwing errors due to the logic in these functions.

Version details

• Liquidsoap 2.2.0+git@2a3bf62
• Docker version 20.10.22, build 3a2c30b
• Imagesavonet/liquidsoap:rolling-release-v2.2.x

Install method
Docker

Common issues
Not an issue previously with 2.1.4

[toots]

This looks like a scopping/variable name override issue. The request variable name in the handler overrides the request module which is used to call `request.destroy.

This should work:

def flushAndSkip(_, response) =
  s = my_source
  q = s.queue()
  s.set_queue([])
  s.skip()
  list.iter(request.destroy, q)
  response.data("The queue was flushed!")
end

[danbo]

Yes, my bad, thank you...

@toots

I was hoping to raise a PR to change the method parameters so they don't collide like they did in my case... is the documentation generated or would I change it here? https://github.com/savonet/savonet.github.io/blob/master/doc-dev/harbor_http.html

[redimongo]

So how do you get it to work?