-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sass --embedded
in pure JS mode
#2413
base: main
Are you sure you want to change the base?
Conversation
8d7d4de
to
7084da7
Compare
e66df5b
to
d53fcc5
Compare
d7e6206
to
b3794eb
Compare
9112b44
to
54fabf3
Compare
257b4fd
to
ac718ee
Compare
9cc1a2f
to
1586bbd
Compare
This PR is on my radar, it's just been a very review-heavy few weeks for me and this is unfortunately on the low end of the priority spectrum. |
6a51bdf
to
d11f856
Compare
9e7f584
to
3d1c155
Compare
99577d1
to
d3c7314
Compare
GitHub Actions revealed an interesting race condition - running To overcome this issue, I decided to use the first byte we added to the message buffer to explicitly send the |
d3c7314
to
1cb26f3
Compare
Ok, one more quirk for node worker. The way stdout/stderr stream in the worker thread works is that the worker posts message to the main thread and then the main thread writes the message asynchronously. So we cannot eagerly exit the main isolate, or otherwise the error message that the worker printed to stderr might get lost. |
1cb26f3
to
5d9c449
Compare
5d9c449
to
2fff2e7
Compare
Closes #2325.
sass/embedded-host-node#344
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing