TASK: Add findBy method in Repository.stub #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabbelasichon
force-pushed
the
issue-156
branch
from
b50825d
to
825a8a3
Compare
sabbelasichon
force-pushed
the
issue-156
branch
from
825a8a3
to
a30c83a
Compare
sascha-egerer
requested changes
Feb 14, 2024
stubs/Repository.stub
Outdated
Comment on lines
66
to
67
| * @phpstan-param array<non-empty-string, mixed> $criteria | ||
| * @phpstan-param array<non-empty-string, QueryInterface::ORDER_*>|null $orderBy |
There was a problem hiding this comment.
Do wo need these both? I think we have put this into a v13 specific stub. What do you think? See https://github.com/sascha-egerer/phpstan-typo3/blob/master/src/Stubs/StubFilesExtensionLoader.php
stubs/QueryInterface.stub
Outdated
Comment on lines
9
to
11
| public const ORDER_ASCENDING = 'ASC'; | ||
| public const ORDER_DESCENDING = 'DESC'; | ||
|
|
There was a problem hiding this comment.
Why have these to been added here?
sabbelasichon
force-pushed
the
issue-156
branch
7 times, most recently
from
6c55498
to
aa9a9e4
Compare
sabbelasichon
force-pushed
the
issue-156
branch
from
aa9a9e4
to
ce82256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #156