Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.mod - Error when terminating an instance #1861

Closed
madhurrya opened this issue Jul 3, 2024 · 2 comments
Closed

dev.mod - Error when terminating an instance #1861

madhurrya opened this issue Jul 3, 2024 · 2 comments

Comments

@madhurrya
Copy link
Contributor

madhurrya commented Jul 3, 2024

Getting this error when trying to terminate instances.

Image

I don't get that error for this simple model
https://dev.mod.spiff.status.im/process-models/misc:qa:forms:simple-form-name-age

But it happens for Status models like PP1, PP2, Expense report

Update : This seems to happen in dev.app also

@jasquat
Copy link
Contributor

jasquat commented Jul 3, 2024

From slack conversation:

[07:49]
Elizabeth Esswein
 I can't see the diagrams in 1530 butin 1861, you can fix this error by putting an exclusive gateway before the two inputs to 'Get Name'.

07:53
Madhurya
 In 1861 there's no issue with the models. That error happens when terminating the instances. I think something introduced with the latest code.
07:55
Elizabeth 1530 and 1861 are not related to the BPMN things I mentioned above :slightly_smiling_face:

[07:56]
Elizabeth Esswein
 Often models with direct inputs to tasks get this recursion error (I guess it doesn't happen in this case because of the boundary event.
07:58
"Maximum recursion depth" errors are frequently caused by having two inputs to a task without an intervening gateway.

I think the correct thing to do is add a validation in bpmn-js-spiffworkflow telling users that this is invalid. A task cannot have multiple inputs. They must be merged with an exclusive gateway at least.

Also relates to #1368 and #1530

@madhurrya
Copy link
Contributor Author

@jasquat Terminate was working fine earlier. This started happening after the latest code update. So it can't be related to a model issue I guess?
It works fine this model https://dev.mod.spiff.status.im/process-models/misc:qa:forms:simple-form-name-age
Issue is with Status models. It was working fine for them earlier. This happens in dev.app also. So not a celery related thing I guess.

@github-project-automation github-project-automation bot moved this from New Issue to Resolved in SpiffWorkflow Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

No branches or pull requests

3 participants