Suppress warnings from imagecreatefromstring #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mattmcdonald-uk! Could you provide more details on how to reproduce this issue? Could you share the image that you've used and PHP error reporting level that's configured on your system? We would like to avoid suppressing the error, because we may miss other errors, that's why we'd like to try to reproduce the issue first |
|
Sure - attached an image that causes the error.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagecreatefromstringhandles warnings as errors, and throws exceptions that wouldn't impact creating images.For example:
imagecreatefromstring(): gd-png: libpng warning: iCCP: known incorrect sRGB profileThis is a warning, and creating images work fine when the warning is ignored.
This pull request suppresses those warnings so they don't cause unnecessarily failures.