Scale only cpu via millis

sapcc · Sep 19, 2023 · 974053e · 974053e
1 parent 5ce026a
commit 974053e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/internal/controllers/vpa_runnable.go b/internal/controllers/vpa_runnable.go
@@ -73,7 +73,7 @@ func (v *VpaRunnable) reconcile(ctx context.Context) {
 		largest := maxByMemory(viable)
 		containers := int64(len(target.PodSpec.Containers))
 		// distribute a fraction of maximum capacity evenly across containers
-		cpuScaled := scaleQuantity(largest.Status.Allocatable.Cpu(), v.CapacityPercent/containers)
+		cpuScaled := scaleQuantityMilli(largest.Status.Allocatable.Cpu(), v.CapacityPercent/containers)
 		memScaled := scaleQuantity(largest.Status.Allocatable.Memory(), v.CapacityPercent/containers)
 		err = v.patchMaxRessources(ctx, patchParams{
 			vpa:    target.Vpa,
@@ -167,6 +167,10 @@ func maxByMemory(nodes []corev1.Node) corev1.Node {
 	return maxNode
 }
 
-func scaleQuantity(q *resource.Quantity, percent int64) *resource.Quantity {
+func scaleQuantityMilli(q *resource.Quantity, percent int64) *resource.Quantity {
 	return resource.NewMilliQuantity(q.MilliValue()*percent/scaleDivisor, q.Format)
 }
+
+func scaleQuantity(q *resource.Quantity, percent int64) *resource.Quantity {
+	return resource.NewQuantity(q.Value()*percent/scaleDivisor, q.Format)
+}