Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task](elektra): landingpage upgrade juno-ui-components and adjust Pageheader with SAP logo #1432

Open
4 tasks done
edda opened this issue Oct 14, 2024 · 0 comments
Open
4 tasks done
Assignees

Comments

@edda
Copy link
Collaborator

edda commented Oct 14, 2024

Task Description
Between the version of juno-ui-components that is currently in use in Elektra and the latest version of juno-ui-components there has been a change that is breaking for the landing page app. The change is that by default we do not render the SAP logo but the Juno logo. In order to have the SAP logo for the Elektra landing page it needs to be imported separately and passed to the Pageheader as a prop (see PageHeader storybook documentation).

Sub-tasks

  • Update juno-ui-components to latest version
  • add SAP logo svg to landingpage app
  • pass SAP logo as a component as prop logo to PageHeader
  • verify that juno-ui-components upgrade doesn't break anything in Keymanager app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants