Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit is in the runtime classpath for the Muxer artefact #433

Open
ditn opened this issue Mar 8, 2021 · 0 comments · May be fixed by #434
Open

JUnit is in the runtime classpath for the Muxer artefact #433

ditn opened this issue Mar 8, 2021 · 0 comments · May be fixed by #434

Comments

@ditn
Copy link

ditn commented Mar 8, 2021

We're consuming a library that uses mp4parser under the hood.

Running ./gradlew -q app:dependencies gives us this output for our debugRuntimeClasspath:

|    |    |    +--- org.mp4parser:isoparser:1.9.41
|    |    |    |    \--- org.slf4j:slf4j-api:1.7.24
|    |    |    \--- org.mp4parser:muxer:1.9.41
|    |    |         +--- org.mp4parser:isoparser:1.9.41 (*)
|    |    |         \--- junit:junit:4.12
|    |    |              \--- org.hamcrest:hamcrest-core:1.3

JUnit should probably not be included in your release artefacts - it increases the size of your binary and for Android consumers, it causes Leak Canary to fail to run.

For those experiencing this issue, there's a simple enough workaround:

implementation("org.mp4parser:muxer:1.9.41") {
        exclude(group = "junit", module = "junit")
}
@pablisco pablisco linked a pull request Mar 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move junit to the test scope pablisco/mp4parser
1 participant
@ditn