Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websockets.legacy now deprecated with websockets v14.0 #77

Open
devennavani opened this issue Nov 10, 2024 · 0 comments · May be fixed by #78
Open

websockets.legacy now deprecated with websockets v14.0 #77

devennavani opened this issue Nov 10, 2024 · 0 comments · May be fixed by #78

Comments

@devennavani
Copy link

websockets v14.0 was released yesterday which deprecates use of websockets.legacy:

https://github.com/python-websockets/websockets/blob/f0d20aafab027e9b99460b193dcb709872b219a5/src/websockets/legacy/__init__.py#L7

This breaks sanic-testing as it relies on websockets.legacy via from websockets.legacy.client import connect in websocket.py

The websockets upgrade guide suggests replacing from websockets.legacy.client import connect with from websockets.asyncio.client import connect
@howard36 howard36 linked a pull request Nov 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update websockets to v14.0 howard36/sanic-testing
1 participant
@devennavani