Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-402 - Specify 'no. pools' rather than 'no. samples per pool' in submission #4467

Open
wants to merge 42 commits into
base: migrating-to-number-of-pools-epic
Choose a base branch
from

Refactoring long methods

9ef7c10
Select commit
Loading
Failed to load commit list.
Open

Y24-402 - Specify 'no. pools' rather than 'no. samples per pool' in submission #4467

Refactoring long methods
9ef7c10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 28, 2024 in 1s

89.21% (-0.02%) compared to 2f7cdbe

View this Pull Request on Codecov

89.21% (-0.02%) compared to 2f7cdbe

Details

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (2f7cdbe) to head (9ef7c10).

Files with missing lines Patch % Lines
.../models/submission/validations_by_template_name.rb 96.87% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           migrating-to-number-of-pools-epic    #4467      +/-   ##
=====================================================================
- Coverage                              89.22%   89.21%   -0.02%     
=====================================================================
  Files                                   1392     1392              
  Lines                                  29830    29887      +57     
=====================================================================
+ Hits                                   26616    26663      +47     
- Misses                                  3214     3224      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.