Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-WIP scRNA Core pipeline record loader files #4352

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

harrietc52
Copy link
Contributor

@harrietc52 harrietc52 commented Sep 18, 2024

Closes #4344

Dependencies

sanger/limber#1939

Changes proposed in this pull request

  • un-WIP scRNA Core pipeline record loader files

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (fa75ca3) to head (fa6f4d5).
Report is 48 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4352      +/-   ##
===========================================
- Coverage    87.62%   87.59%   -0.04%     
===========================================
  Files         1383     1383              
  Lines        29881    29881              
===========================================
- Hits         26183    26174       -9     
- Misses        3698     3707       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to deploy this change to training first along with the corresponding Limber WIP changes, and run the scRNA integration suite test against it. So maybe not merge into develop immediately? Can discuss with other scRNA devs.

@andrewsparkes andrewsparkes merged commit 41d0980 into develop Sep 25, 2024
22 of 23 checks passed
@andrewsparkes andrewsparkes deleted the y24-326 branch September 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-326 - Un-WIP scRNA Core pipeline
2 participants