Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-366 - As a staff scientist I would like to have a separate submission for the new BGE pipeline. #4402

Open
9 tasks done
BenTopping opened this issue Oct 8, 2024 · 5 comments · May be fixed by #4511
Open
9 tasks done
Assignees
Labels
BGE Size: S Small - low effort & risk Value: 3 Value to the insitute is average

Comments

@BenTopping
Copy link
Contributor

BenTopping commented Oct 8, 2024

User story
As a staff scientist (Matt M) I would like to have a separate submission for the new BGE pipeline. This submission is required for the new BGE Limber pipeline to function.

Who are the primary contacts for this story
Matt M, Sara W, Liz C, Katy T, Ben T

Who is the nominated tester for UAT
Matt M, Sara W, Liz C

Acceptance criteria
To be considered successful the solution must allow:
This will be the initial submission

  • Add a new request type limber_bge_pcr_free (copy of PCR Free request)
  • Add a new submission template for BGE pipeline (name based on its contents or ask stakeholders)
    • Submission includes new BGE request (copy of PCR Free request) and a multiplexing request

This will be the second, automated submission
This submission is purely for pipeline 3 in the lucid chart. A small limber pipeline to move plates across from PCR Free to ISC.

  • Add a new request type limber_bge_transition (not sure on the name or the request type as its not strictly library prep)
  • Add a new submission template for BGE transition
    • includes new BGE transition request

This will be a third submission on BGE ISC

  • Add a new request type limber_bge_isc (copy of ISC request)
  • Add a new submission template for BGE ISC pipeline (name based on its contents or ask stakeholders)
    • Submission includes new BGE ISC request (copy of ISC request) and a multiplexing request

References
This story has a non-blocking relationship with:

Additional context

  • BGE Library type already exists
  • The pooling (prior to blending) strategy will be specified in this new submission, in the normal way (using the submission name to group pools together).
  • BGE Research doc (contains link to lucid chart pipeline design)
@BenTopping BenTopping added Size: S Small - low effort & risk Value: 3 Value to the insitute is average BGE labels Oct 8, 2024
@psd-issuer psd-issuer bot changed the title As a staff scientist I would like to have a separate submission for the new BGE pipeline. Y24-366 - As a staff scientist I would like to have a separate submission for the new BGE pipeline. Oct 8, 2024
@KatyTaylor
Copy link
Contributor

The third submission will be an 'automated' one - created by Limber through the API. Consider using submission_class_name AutomatedOrder on the submission template. We don't seem to be using it for all our automated submissions, but perhaps should for this one.

@KatyTaylor
Copy link
Contributor

Think ideally the submission would include the blending and sequencing (Novaseq) request types too. Could add that in here, or will it come in later in the blending stories?

@dasunpubudumal
Copy link
Contributor

Hi @BenTopping @KatyTaylor, I have partially implemented the changes in #4511. A couple of questions:

  1. For the submission made with limber_bge_pcr_free and limber_bge_isc request types, do we need theillumina_htp_novaseqx_paired_end_sequencing in request_type_keys?
  2. Are there any other additional request type keys for the submission related to the limber_bge_transition request?
  3. I have named the submissions the following. Do we need to change them?
    • Limber-Htp - BGE PCR Free
    • Limber-Htp - BGE Transition
    • Limber-Htp - BGE ISC
  4. The transition request type uses a IlluminaHtp::Requests::StdLibraryRequest. Is this correct or does this require a different type?

@BenTopping
Copy link
Contributor Author

@dasunpubudumal

  1. For the time being I think we can leave the sequencing requests off them until we get to the later stages of the pipeline and understand which requests are needed.
  2. Just one request.
  3. Look fine for the time being, im not sure if they classify as Htp (High throughput) - but these are just preliminary submissions to help with testing the pipeline so as long as they are wip'd we can change them down the line. Since BGE Transition is automated we could rename to Limber - BGE Transition - Automated
  4. Good question, im not sure. Does the standard library request associate any unique data with the submission? We don't need any extra data, purely a request to help with the limber pipeline.

@KatyTaylor
Copy link
Contributor

  1. I'm hoping that we can include two extra request types in the upfront (pcr free) submission, one for the 'blending' step and one for the sequencing step. But, like Ben said, we probably need to leave them off until later on as we haven't quite figured out the blending step yet.
  2. Agree with Ben
  3. Agree with Ben
  4. Library requests normally have a library type associated with them - not sure if it's mandatory. Could try a 'customer request' instead. Or, can set the library type as BGE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BGE Size: S Small - low effort & risk Value: 3 Value to the insitute is average
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants