API v2 Milestone 3 #2099
API v2 Milestone 3 #2099
Conversation
when preparing transfer_requests_attributes
spec/features/pooling_multiple_tubes_into_one_tube_spec.rb spec/models/labware_creators/donor_pooling_plate_spec.rb spec/models/labware_creators/plate_split_to_tube_racks_spec.rb spec/models/labware_creators/pooled_wells_by_sample_in_groups_spec.rb
with calls to the helper function
over to common helper methods
to be fair, this was a good suggestion!
Y24-190: Use api v2 plate everywhere
Clear unneeded v1 mocks out of tests
…on-with-a-template Y24-190: Use v2 tag layout creation with a template
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2099 +/- ##
===========================================
+ Coverage 80.43% 80.65% +0.21%
===========================================
Files 471 477 +6
Lines 17932 18146 +214
Branches 268 268
===========================================
+ Hits 14424 14636 +212
- Misses 3506 3508 +2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sdjmchattie
requested review from
yoldas,
wendyyang,
andrewsparkes,
BenTopping and
StephenHulme
| response = api.qc_file.find(params[:id]).retrieve | ||
| filename = /filename="([^"]*)"/.match(response['Content-Disposition'])[1] || 'unnamed_file' | ||
| send_data(response.body, filename: filename, type: 'sequencescape/qc_file') | ||
| qc_file = Sequencescape::Api::V2::QcFile.find(uuid: params[:id]).first |
There was a problem hiding this comment.
Is there a way we can hide the long winded Sequencescape::Api::V2:: naming all over the codebase? for api 1 we seem to do the much shorter api naming
There was a problem hiding this comment.
We could (in a separate piece of work) create an alias for the Sequencescape::Api::V2 module. Maybe something like SSAPIv2 so that these would become SSAPIv2::QcFile etc. I don't think we should name the real module differently, but an alias would be a reasonable approach.
This allows us to get the stock_plate and its attributes without making requests repeatedly over the API
sdjmchattie
force-pushed
the
api-v2-milestone-3
branch
from
81aa90a to
1e05aaf
Compare
| stock_plates.order(id: :asc).last | ||
| # Note that it's only when we call last that we get an actual object to cache. | ||
| # If we cache the query to the API, then it will still be made every time we call stock_plate. | ||
| @stock_plate ||= fetch_stock_plate_ancestors.order(id: :asc).last |
There was a problem hiding this comment.
@andrewsparkes and @StephenHulme This is the fix for the repeated requests for stock plates. I've added a comment to make it clearer to future maintainers, but basically we were caching the query object back in the stock_plates method and not the stock plate itself. The query object is cheap to create and hasn't made a request to the API at the time we were caching it. Instead we need to cache the response which is only obtained after you call last on this line. This gives us the speed up we need AFAIK.
|
|
||
| it 'returns the stock plates because that must be cool' do |
There was a problem hiding this comment.
I think someone was having a bad day when they chose these test names.
Closes #1818
Changes proposed in this pull request
All has been reviewed before, but this is a last once over before going into
develop.bulk_transfersplatesplate_conversionsplate_creationsqc_filessubmission_poolstransfer_request_collectionstransferstubestube_from_tube_creationsInstructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code