Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scRNA - Pooling calculation stories Epic #2069

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

scRNA - Pooling calculation stories Epic #2069

wants to merge 25 commits into from

Commits on Nov 5, 2024

  1. refactored shared constants to move them into a central config file

    @andrewsparkes
    andrewsparkes committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c280f87 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. renamed constants to make more specific, and added usage of study ove… 

    …rride of required_number_of_cells_per_sample_in_pool in export files
    @andrewsparkes
    andrewsparkes committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ac4e199 View commit details
    Browse the repository at this point in the history

  2. added check for when no polymetadata exists

    @andrewsparkes
    andrewsparkes committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0fd92ec View commit details
    Browse the repository at this point in the history

  3. removed references to override from study value and added check for n… 

    …ew override from pool well polymetadata
    @andrewsparkes
    andrewsparkes committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8e2c12a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. fix key name

    @andrewsparkes
    andrewsparkes authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bb3de69 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. removed references to unneeded number of cells per chip well constant… 

    … and added error check for poly metadata
    @andrewsparkes
    andrewsparkes committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    80a10e6 View commit details
    Browse the repository at this point in the history

  2. reduced number of decimal places for wastage factor

    @andrewsparkes
    andrewsparkes committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f89a1c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Update app/views/exports/hamilton_gem_x_5p_chip_loading.csv.erb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2f90573 View commit details
    Browse the repository at this point in the history

  2. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1404745 View commit details
    Browse the repository at this point in the history

  3. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    eac6a5e View commit details
    Browse the repository at this point in the history

  4. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    729c220 View commit details
    Browse the repository at this point in the history

  5. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5090dab View commit details
    Browse the repository at this point in the history

  6. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    762b8be View commit details
    Browse the repository at this point in the history

  7. Update config/initializers/scrna_config.rb 

    Co-authored-by: KatyTaylor <[email protected]>
    @andrewsparkes @KatyTaylor
    andrewsparkes and KatyTaylor authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    54a81e8 View commit details
    Browse the repository at this point in the history

  8. linted

    @andrewsparkes
    andrewsparkes committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    565facb View commit details
    Browse the repository at this point in the history

  9. added comments to describe what is happening in calculations

    @andrewsparkes
    andrewsparkes committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d9e10de View commit details
    Browse the repository at this point in the history

  10. fixed tests due to changed wastage factor

    @andrewsparkes
    andrewsparkes committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1166fc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'y24-375-file-downloads-improvements-for-mvp' into scrna… 

    …-pooling-calculation-epic
    @andrewsparkes
    andrewsparkes committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2cb2ef4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. added method to fetch number of cells per chip well from the request … 

    …metadata
    @andrewsparkes
    andrewsparkes committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2818c15 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. added additional constants for allowance calculation

    @andrewsparkes
    andrewsparkes committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c96d434 View commit details
    Browse the repository at this point in the history

  2. added methods to donor pooling calculator for allowance calculations

    @andrewsparkes
    andrewsparkes committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2d17ea3 View commit details
    Browse the repository at this point in the history

  3. added check for full allowance

    @andrewsparkes
    andrewsparkes committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bff091d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. removed unneeded parameter in tests

    @andrewsparkes
    andrewsparkes committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    59c7b08 View commit details
    Browse the repository at this point in the history

  2. renamed test class instance variable

    @andrewsparkes
    andrewsparkes committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    57fcd22 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Merge pull request #2078 from sanger/Y24-384-scrna-adjust-pooling-for… 

    …-full-allowance

Y24-384 scRNA - adjust pooling for full allowance
    @andrewsparkes
    andrewsparkes authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ca0f7e4 View commit details
    Browse the repository at this point in the history