Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk support? #12

Open
peterjc opened this issue Sep 26, 2018 · 1 comment
Open

openjdk support? #12

peterjc opened this issue Sep 26, 2018 · 1 comment

Comments

@peterjc
Copy link

peterjc commented Sep 26, 2018

We have this version of Java installed,

$ java -version
openjdk version "1.8.0_92"
OpenJDK Runtime Environment (Zulu 8.15.0.1-linux64) (build 1.8.0_92-b15)
OpenJDK 64-Bit Server VM (Zulu 8.15.0.1-linux64) (build 25.92-b15, mixed mode)

Hacking the regular expression match = re.match('^java version "1\.7\.[^"]+"$', first_line) to read match = re.match('^openjdk version "1\.8\.[^"]+"$', first_line) in snpEffWrapper/wrapper.py seems to be enough to run the tool.

Is there good reason not to accept openjdk and versions after 1.7.x?

@peterjc
Copy link
Author

peterjc commented Sep 26, 2018

Also the README file says Java (>= 1.7), yet the code requires Java 1.7.x only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant