Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Fences For Stolen Qthreads #265

Open
insertinterestingnamehere opened this issue Aug 7, 2024 · 1 comment
Open

Check Fences For Stolen Qthreads #265

insertinterestingnamehere opened this issue Aug 7, 2024 · 1 comment

Comments

@insertinterestingnamehere
Copy link
Collaborator

We need to confirm that we handle the memory fencing correctly for the case where a qthread suspends and then gets stolen to another shepherd. It's not currently obvious to me if/where that's getting handled right now, and some of the thread sanitizer errors seem to be pointing toward this as an issue. The threadqueues should be providing the ordering constraint for the safety of migration, but the corresponding fences need to be handled as a part of the suspend/resume process.

@insertinterestingnamehere
Copy link
Collaborator Author

Taking this one off the 1.21 release milestone since figuring out how to do this safely without causing performance regressions is likely to be a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant