-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Fences For Stolen Qthreads #265
Labels
Comments
Taking this one off the 1.21 release milestone since figuring out how to do this safely without causing performance regressions is likely to be a pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to confirm that we handle the memory fencing correctly for the case where a qthread suspends and then gets stolen to another shepherd. It's not currently obvious to me if/where that's getting handled right now, and some of the thread sanitizer errors seem to be pointing toward this as an issue. The threadqueues should be providing the ordering constraint for the safety of migration, but the corresponding fences need to be handled as a part of the suspend/resume process.
The text was updated successfully, but these errors were encountered: