-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deliberate Symbol Visibility #165
Comments
Generally internal functions should already be prefaced with "INTERNAL", e.g.:
It is possible that some functions are not properly marked though. |
Okay, just looked into the status of this a bit more. External API functions and some internal stuff is all marked. I think the only change needed here is setting |
It's generally a good a idea to set the default symbol visibility to "hidden" while compiling a library so that internal functions don't get automatically included in the interface exposed to downstream projects. This will require tagging which functions are supposed to be exported and setting up some build flags and ifdefs to turn on symbol exports only when building the main qthreads shared object.
The text was updated successfully, but these errors were encountered: