Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an XpcConnection.prototype.stop() method #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add an XpcConnection.prototype.stop() method #20

wants to merge 2 commits into from

Conversation

chee
Copy link

@chee chee commented Jul 13, 2017

for #16 and @sandeepmistry/noble#299 and this comment
on @sandeepmistry/noble#577.

now admittedly i have no idea what i'm doing here, but it does appear to work. at first i tried canceling the connection with xpc_connection_cancel(this->xpcConnection) but it sure took that badly

so now it is closing and deleting the handle like it would in the destructor

i do not know if this is the right thing to do, but it seems to work (does not prevent the node process from ending)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant