Change name of hal functions to ease integration with esphome. #676
Closed
msteenhuiz
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is a request to change some hal function names.
Some names have a clash with esphome.
I see workarounds for that.
How open are you to change some hal names to ease integration?
For instance I see in integrations with esp home for home assistant that this can be done only by undefing defines that are used by esphome. It concerns the following:
#undef yield
#undef millis
#undef micros
#undef delay
#undef delayMicroseconds
So I assume that if these names are changed in the hal layer the conflict is gone.
Something like hal_delay or os_delay?
Is that an option?
Beta Was this translation helpful? Give feedback.
All reactions