Reduce the number of bytes over SPI for MCP2515Class::parsePacket() by up to 2.8x #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timurrrr
force-pushed
the
optimize_parse_packet
branch
from
89d49b5
to
75e91ef
Compare
1) Use the RX STATUS command instead of READ(CANINTF) to check availability of data to read. This reduces SPI usage for a simple "is data available" check from 3 bytes to 2. 2) Use the READ RX BUFFER command to read the RXFn* registers as well as the received data. This requires doing only a single CS pull, and only N+6 bytes transferred over SPI. READ RX BUFFER also takes care of resetting the RXnIF flag. If my math is right, the old code needed N+6 readRegister() calls for a standard frame, and N+9 readRegister() calls for an extended frame, plus one modifyRegister() call to reset the RXnIF flag. Each readRegister() call requires a CS pull and transferring 3 bytes over SPI. For N = 8, - we now send 16 bytes over SPI vs 45 for a standard frame (>2.8x reduction!) - we now do just 2 CS pulls vs 16 for a standard frame (8x reduction!)
timurrrr
force-pushed
the
optimize_parse_packet
branch
from
75e91ef
to
828a145
Compare
|
Came up with an even better idea, force-pushed an update into the branch so you can avoid looking at the less optimal intermediate solution. |
timurrrr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the RX STATUS command instead of READ(CANINTF) to check availability of
data to read. This reduces SPI usage for a simple "is data available" check
from 3 bytes to 2.
Use the READ RX BUFFER command to read the RXFn* registers as well as the
received data. This requires doing only a single CS pull, and only N+6 bytes
transferred over SPI. READ RX BUFFER also takes care of resetting the RXnIF
flag.
If my math is right, the old code needed N+6 readRegister() calls for a standard
frame, and N+9 readRegister() calls for an extended frame, plus one
modifyRegister() call to reset the RXnIF flag. Each readRegister() call requires
a CS pull and transferring 3 bytes over SPI.
For N = 8,