Implement filtering for multiple CAN ids #20
Conversation
…er for multiple can ids (standard only for now)
|
Hi, is this ever implemented? Thank you for this beautiful and simple for use library! |
|
@sandeepmistry Do you think this could be merged? I have a requirement to filter for two IDs, currently this does need to be done in the MCU, while with this PR it could be done natively in the CAN controller (if you have enough filter registers). |
|
|
||
| // normal mode | ||
| writeRegister(REG_CANCTRL, 0x00); | ||
| if (readRegister(REG_CANCTRL) != 0x00) { |
There was a problem hiding this comment.
You should probably put this into the same mode as it previously was (read mode before setting to config?). Or document that this function explicitely puts the controller into normal mode, so users are not surprised.
There was a problem hiding this comment.
The datasheet says
In Listen-Only mode, both valid and invalid messages will
be received, regardless of filters and masks or the
Receive Buffer Operating Mode bits, RXMn.
This code matches the existing behavior implemented in filter() that resets the mode to "normal" on lines 307-311.
i tried to keep the interface simple for the user, you simply specify a list of CAN ids you are interrested in and the library handles when the hardware does not have enough filter registers.
ref #19