-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Automatic Draper Include #770
Comments
After discussion today at Samvera Connect, I'm going to take a hack at deprecating draper inclusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
Valkyrie::Resource#decorate
is called, but there wasn't an explicitinclude Draper::Decoratable
, it should throw a deprecation warning telling the developer to explicitly includeDraper::Decoratable
in their project.Possible Implementation (needs testing)
Create a module which includes
Draper::Decoratable
, override#decorate
in that module to throw the deprecation warning, and then include that module inValkyrie::Resource
.Previous ticket text below.
Resource
includesDraper::Decoratable
by default.Since this injects a variety of behavior (including overrides for simple operations like
#==
viaDraper::Decoratable::Equality
) that some users may want, while others may not expect. Since adding this behavior locally is as easy asinclude Draper::Decoratable
, shouldValkyrie::Resource
decline to provide it by default?The text was updated successfully, but these errors were encountered: