Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ACLs from hydra-access-controls to a new gem? #53

Open
jcoyne opened this issue May 6, 2015 · 3 comments
Open

Move ACLs from hydra-access-controls to a new gem? #53

jcoyne opened this issue May 6, 2015 · 3 comments
Labels
Advanced question

Comments

@jcoyne
Copy link
Member

jcoyne commented May 6, 2015

That way current hydra-access-controls could continue to use what they have and hydra-pcdm users would get that functionality too.
@jcoyne jcoyne added the question label May 6, 2015
@jcoyne jcoyne added this to the May Hydra PCDM milestone May 6, 2015
jcoyne added a commit that referenced this issue May 6, 2015
@jcoyne
Remove tests for descriptive and access metadata
e12bf7f 
That functionality lives in ActiveFedora and Hyra::AccessControls.
We don't need to test for it here.

See #53 for further discussion of where ACLs belong.
@jcoyne jcoyne mentioned this issue May 6, 2015
Merged
jcoyne added a commit that referenced this issue May 7, 2015
@jcoyne
Remove tests for descriptive and access metadata
94c7056 
That functionality lives in ActiveFedora and Hyra::AccessControls.
We don't need to test for it here.

See #53 for further discussion of where ACLs belong.
jcoyne added a commit that referenced this issue May 7, 2015
@jcoyne
Remove tests for descriptive and access metadata
058ca6e 
That functionality lives in ActiveFedora and Hyra::AccessControls.
We don't need to test for it here.

See #53 for further discussion of where ACLs belong.
jcoyne added a commit that referenced this issue May 7, 2015
@jcoyne
Remove tests for descriptive and access metadata
ae1d128 
That functionality lives in ActiveFedora and Hyra::AccessControls.
We don't need to test for it here.

See #53 for further discussion of where ACLs belong.
@flyingzumwalt
Copy link
Member

It sounds like you're implying that it would be a bad idea to make hydra-pcdm depend on hydra-access-controls. Is that right? Why is that?

@jcoyne
Copy link
Member Author

jcoyne commented May 7, 2015

Mostly because it will pull in too many extra dependencies. hydra-access-controls depends on Blacklight which depends on Rails.

@flyingzumwalt
Copy link
Member

Oh. Then 👍 to moving ACLs to a new gem. Definitely shouldn't need to include blacklight and rails in order to assert & evaluate ACLs.

@mjgiarlo mjgiarlo added the pcdm label Jul 9, 2015
@mjgiarlo mjgiarlo modified the milestones: May Hydra PCDM, summer-2015 Jul 9, 2015
@mjgiarlo mjgiarlo removed this from the summer-2015 milestone Jul 13, 2015
@jrgriffiniii jrgriffiniii mentioned this issue Aug 2, 2019
Closed
@jrgriffiniii jrgriffiniii removed the pcdm label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Advanced question
Projects
Samvera Component Maintenance
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcoyne @mjgiarlo @flyingzumwalt @jrgriffiniii