-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled errors in promises #47
Comments
hi @BobFrankston can you share your connection code? maybe your device is new model and this code was not updated for awhile |
It shouldn't matter what the device is doing, your code needs to handle errors in promises because Node will terminate the app when there is such an error. |
I just upgraded from 1.0.5 to 1.1.0. I will see if it fixes the problem. |
I've upgraded, but I still get
I presume there is a missing error handler in the TCP connection. |
Could be my error -- I just added (.on('error"). to the connection and it seems to have fixed it. |
I think we should handle if no error listener in client.
THanks, I will update it when have some time
…________________________________
From: Bob Frankston ***@***.***>
Sent: Saturday, August 13, 2022 3:50 AM
To: samuraitruong/yeelight ***@***.***>
Cc: Truong Nguyen ***@***.***>; Comment ***@***.***>
Subject: Re: [samuraitruong/yeelight] Unhandled errors in promises (Issue #47)
Could be my error -- I just added (.on('error"). to the connection and it seems to have fixed it.
—
Reply to this email directly, view it on GitHub<#47 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJA3IXKYT4NXFYQVGIWSKDVY2FHTANCNFSM54PAQDHQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
I'm getting fatal errors because of unhandled failures in promises.
The text was updated successfully, but these errors were encountered: