Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude additional macOS system files and folders commonly created on external drives #1047

Merged
merged 1 commit into from
May 16, 2024

Conversation

samschott
Copy link
Owner

Those are can be not readable without root permissions and certainly will be not be expected to sync since they contain sometimes only temporary system data.

Fixes #1045.

...commonly created on external drives
@samschott samschott force-pushed the exclude-external-volume-items branch from fae0ff5 to a89e3ba Compare May 15, 2024 22:57
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (7666b12) to head (a89e3ba).
Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1047       +/-   ##
===========================================
+ Coverage   55.86%   79.00%   +23.14%     
===========================================
  Files          42       42               
  Lines        7551     7551               
===========================================
+ Hits         4218     5966     +1748     
+ Misses       3333     1585     -1748     
Flag Coverage Δ
pytest 79.00% <ø> (+23.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samschott samschott merged commit b8d34d2 into main May 16, 2024
12 checks passed
@samschott samschott deleted the exclude-external-volume-items branch May 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient read or write permissions for .Spotlight-V100 folder
1 participant