Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and QueryConfig layers #30

Closed
sametcodes opened this issue Mar 7, 2023 · 3 comments · Fixed by #32
Closed

Query and QueryConfig layers #30

sametcodes opened this issue Mar 7, 2023 · 3 comments · Fixed by #32

Comments

@sametcodes
Copy link
Owner

sametcodes commented Mar 7, 2023

We have no view layer. Metric functions are reachable directly from the internet. For instance, even if the user doesn't enable a metric function, other users can still access the metrics functions publicly if the user has a connection on that platform. It causes a privacy issue.

One another problem with the current version is we cannot provide if the metric function requires parameters. It works custom.

The solution is to have a view layer. Views will hold the configurations and parameters provided by users; if a user provides no configuration, nothing will be publicly exposed.

Query layer

Page 4

All the layers after having the View layer

image

@sametcodes sametcodes added this to the MVP Version milestone Mar 7, 2023
@sametcodes sametcodes self-assigned this Mar 7, 2023
@sametcodes sametcodes moved this to 🆕 New in Readme.rocks Mar 7, 2023
@sametcodes sametcodes changed the title Creating view model Create view layer Mar 7, 2023
@sametcodes sametcodes changed the title Create view layer Create Metrics layer Mar 7, 2023
@sametcodes sametcodes changed the title Create Metrics layer Create Query layer Mar 7, 2023
@sametcodes
Copy link
Owner Author

sametcodes commented Mar 7, 2023

  • Make changes on the migration script
  • Platform is not mapping to PlatformQuery on the database
  • Build relations between Platform, User and Query models on the prisma schema
  • Tests will be changed according to new endpoints (see Tests, tests, tests #34)
  • Create an application for localhost development on stackapps (reconsidered that it's not necessary)
  • Remove ts-ignores (see Make the code all typesafed #17)
  • Nivo components returns SVGs in a parent div, it should be trimmed to SVG document
  • The root SVG document should contain xmlns and xlmns:xlink attributes

@sametcodes
Copy link
Owner Author

sametcodes commented Mar 7, 2023

Query, QueryConfig and Platform model relations.

Page 5

@sametcodes sametcodes changed the title Create Query layer New feature: Query and QueryConfig layers Mar 7, 2023
@sametcodes sametcodes changed the title New feature: Query and QueryConfig layers Query and QueryConfig layers Mar 7, 2023
@sametcodes sametcodes moved this from 🆕 New to 🏗 In progress in Readme.rocks Mar 7, 2023
@sametcodes
Copy link
Owner Author

How the View API works:

Page 3

sametcodes added a commit that referenced this issue Mar 8, 2023
@sametcodes sametcodes linked a pull request Mar 8, 2023 that will close this issue
sametcodes added a commit that referenced this issue Mar 8, 2023
sametcodes added a commit that referenced this issue Mar 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Readme.rocks Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
1 participant