Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx configuration dependencies unresolvable with alphabetically sorted processing of pillars #102

Open
johnkeates opened this issue Dec 16, 2015 · 2 comments

Comments

@johnkeates
Copy link
Contributor

If you want to set some sort of an option in nginx that depends on another option being set before, it breaks if the options don't follow each other alphabetically.

For example, access_log has an option to define a custom format. But the custom log format gets ordered below the access_log entry due to sorting happening in either the map.jinja or in the sls_block/nginx macro. This way, access_log can never find it's custom settings because it's always defined below it (since access_log starts with an A).

@EvaSDK
Copy link
Contributor

EvaSDK commented Mar 3, 2016

This is the same as issue #40

lingonl added a commit to lingonl/nginx-formula that referenced this issue May 26, 2016
Adding sort_keys=False to json() allows nginx.server.config to be sorted as needed for the resulting config file to work with access_log+log_format (issue saltstack-formulas#102) and other parameters (issue saltstack-formulas#40)
@noelmcloughlin
Copy link
Member

See: saltstack/salt#12161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants