Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSR] Make dynamic import()s no-ops #4875

Open
nolanlawson opened this issue Nov 15, 2024 · 1 comment
Open

[SSR] Make dynamic import()s no-ops #4875

nolanlawson opened this issue Nov 15, 2024 · 1 comment
Labels
BUG P3 SSR

Comments

@nolanlawson
Copy link
Collaborator

nolanlawson commented Nov 15, 2024 •
edited
Loading

In the SSR compiler, dynamic import()s should (probably) be no-ops because we run in sync mode so you wouldn't be able to do anything with the constructor you import anyway.

We also need to strip these import()s anyway because core will complain if it sees them after compilation.
@nolanlawson nolanlawson changed the title [SSR] Make dynamic import()s no-ops and block importing @lwc/ssr-runtime [SSR] Make dynamic import()s no-ops Nov 15, 2024
@git2gus Git2Gus
Copy link

git2gus bot commented Nov 15, 2024

This issue has been linked to a new work item: W-17248485

@nolanlawson nolanlawson mentioned this issue Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG P3 SSR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson