Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP redirect in IP filtering feature #12

Open
Tracked by #14508
jakubkuc opened this issue Nov 7, 2023 · 1 comment
Open
Tracked by #14508

Add support for HTTP redirect in IP filtering feature #12

jakubkuc opened this issue Nov 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jakubkuc
Copy link
Member

jakubkuc commented Nov 7, 2023

Passing allow_redirects flag to requests should be handled in requests-hardened.
At the moment it is not possible and additional code is needed to be able to use redirects while using requests-hardened and that is not optimal for Saleor.

@jakubkuc jakubkuc added the bug Something isn't working label Nov 7, 2023
@NyanKiyoshi NyanKiyoshi changed the title Handle allow_redirects Add support for HTTP redirect in IP filtering feature Nov 7, 2023
@NyanKiyoshi NyanKiyoshi added enhancement New feature or request and removed bug Something isn't working labels Nov 7, 2023
@NyanKiyoshi
Copy link
Member

NyanKiyoshi commented Nov 7, 2023

I removed the bug label as the IP filtering feature works as intended, it's a feature request.

But the following could be improved:

  1. Documentation should warn about the limitation
  2. The configuration should reject mixing ip_filter_enable=True and never_redirect=False as this is unsupported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants