Allow CLI to work with arbitrary Cloud API servers #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lkostrowski
approved these changes
Jan 24, 2024
Comment on lines
-153
to
-155
| `SALEOR_CLI_ENV` | ||
|
|
||
| Set to `staging` to use the CLI with staging Saleor Cloud |
There was a problem hiding this comment.
Why its removed? I see its used in the source code?
There was a problem hiding this comment.
Comment on lines
+22
to
+23
| | 'cloud_api_url' | ||
| | 'cloud_api_auth_domain' |
There was a problem hiding this comment.
can we add these env variables (SALEOR_CLI_ENV_URL and SALEOR_CLI_ENV_AUTH_DOMAIN) to readme?
There was a problem hiding this comment.
karola312
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this PR because
Related (issues, PRs, topics)
Steps to test feature
I have: