Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env cors & env origins commands #687

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add env cors & env origins commands #687

merged 1 commit into from
Oct 12, 2023

Conversation

2can
Copy link
Contributor

@2can 2can commented Oct 11, 2023 •
edited
Loading

I want to merge this PR because

This PR introduces additional commands for environment management. It adds

  • saleor env cors to manage CORS in the environment
  • saleor env origins to manage client-trusted origins in the environment

Related (issues, PRs, topics)

  • #688
  • #689

Steps to test feature

  • saleor env cors
  • saleor env origins

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

@2can 2can force-pushed the env-update branch 3 times, most recently from 940dd2d to 403aec7 Compare October 11, 2023 13:49
@2can 2can marked this pull request as ready for review October 11, 2023 15:40
@zaiste zaiste merged commit 3926ef7 into main Oct 12, 2023
3 checks passed
@zaiste zaiste deleted the env-update branch October 12, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaiste zaiste zaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2can @zaiste