Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env maintenance prompt #683

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix env maintenance prompt #683

merged 2 commits into from
Oct 6, 2023

Conversation

2can
Copy link
Contributor

@2can 2can commented Oct 6, 2023 •
edited
Loading

I want to merge this PR because

  • it fixes the prompt logic for the prompt in the env maintenance command
  • it reorganizes the tests connected with environment update

Related (issues, PRs, topics)

  • NA

Steps to test feature

  • saleor env maintenance

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

@2can 2can marked this pull request as ready for review October 6, 2023 11:10
@2can 2can merged commit 0be3b99 into main Oct 6, 2023
3 checks passed
@2can 2can deleted the env-update branch October 6, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typeofweb typeofweb typeofweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2can @typeofweb