New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to device flow for `github login` #677

Merged

zaiste merged 1 commit into main from gh-device-flow

Sep 20, 2023

Contributor

2can commented Sep 20, 2023 •

edited

Loading

I want to merge this PR because

it switches from Web Application flow to Device flow for GitHub OAuth

Related (issues, PRs, topics)

#673

Steps to test feature

saleor github login

I have:

Tested it locally and it doesn't break existing features
Added documentation if public changes are introduced
Added tests for my code


          Switch to device flow for github login

0aa7e0d

zaiste approved these changes

View reviewed changes

zaiste merged commit 5d01ee2 into main

3 checks passed

zaiste deleted the gh-device-flow branch

September 20, 2023 11:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet