Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types wrong: sync events #247

Closed
JannikZed opened this issue May 25, 2023 · 0 comments · Fixed by #302
Closed

types wrong: sync events #247

JannikZed opened this issue May 25, 2023 · 0 comments · Fixed by #302
Assignees
Labels
bug Something isn't working

Comments

@JannikZed
Copy link

What I'm trying to achieve

Creating a sync webhook with events "PAYMENT_LIST_GATEWAYS" and other payment events.
This is the supported event list according to the GraphQL API:

  PAYMENT_AUTHORIZE
  PAYMENT_CAPTURE
  PAYMENT_CONFIRM
  PAYMENT_LIST_GATEWAYS
  PAYMENT_PROCESS
  PAYMENT_REFUND
  PAYMENT_VOID
  TRANSACTION_CHARGE_REQUESTED
  TRANSACTION_REFUND_REQUESTED
  TRANSACTION_CANCELATION_REQUESTED
  CHECKOUT_CALCULATE_TAXES
  ORDER_CALCULATE_TAXES
  SHIPPING_LIST_METHODS_FOR_CHECKOUT
  ORDER_FILTER_SHIPPING_METHODS
  CHECKOUT_FILTER_SHIPPING_METHODS
  PAYMENT_GATEWAY_INITIALIZE_SESSION
  TRANSACTION_INITIALIZE_SESSION
  TRANSACTION_PROCESS_SESSION

and these events are typed in the app SDK:

import { WebhookManifest } from "@saleor/app-sdk/types";
"CHECKOUT_CALCULATE_TAXES" | "ORDER_CALCULATE_TAXES" | "SHIPPING_LIST_METHODS_FOR_CHECKOUT" | "CHECKOUT_FILTER_SHIPPING_METHODS" | "ORDER_FILTER_SHIPPING_METHODS" | "TRANSACTION_CHARGE_REQUESTED" | "TRANSACTION_REFUND_REQUESTED" | "TRANSACTION_CANCELATION_REQUESTED" | "PAYMENT_GATEWAY_INITIALIZE_SESSION" | "TRANSACTION_INITIALIZE_SESSION" | "TRANSACTION_PROCESS_SESSION"

or am I missing something?

Describe a proposed solution

...

Other solutions I've tried and won't work

Screenshots or mockups

@typeofweb typeofweb assigned typeofweb and unassigned lkostrowski May 25, 2023
@lkostrowski lkostrowski self-assigned this Nov 17, 2023
@lkostrowski lkostrowski linked a pull request Nov 17, 2023 that will close this issue
1 task
@lkostrowski lkostrowski added the bug Something isn't working label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants