-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[updatecli] Bump CAPI Provider versions #10
base: main
Are you sure you want to change the base?
[updatecli] Bump CAPI Provider versions #10
Conversation
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
@@ -11,18 +11,18 @@ data: | |||
providers: | |||
# Cluster API core provider | |||
- name: "cluster-api" | |||
url: "https://github.com/rancher-sandbox/cluster-api/releases/v1.7.7/core-components.yaml" | |||
url: "https://github.com/rancher-sandbox/cluster-api/releases/v1.8.4/core-components.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: updatecli bumps it to the whatever latest version we release in the fork (v1.8.4 in this case), however, when I check https://github.com/rancher-sandbox/cluster-api/releases/tag/v1.8.4 it does not normally include all manifests unless it is re-released after manually running GH workflow https://github.com/rancher/clusterapi-forks/actions/workflows/core.yaml. So, does that mean, we should always verify all release manifests do exists for specific version of project bumped with updatecli PR prior to merging it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point. We could also use updatecli's conditions, which would let us add a validation step before applying changes and opening the PR. It can be used to check for the existence of a file in a release. Perhaps we can take a look at which files we should be looking at before bumping versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files vary depending on if it is an infra provider/core CAPI/bootstrap/controlplane. The only file that all of them should have is metadata.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if files have -components.yaml in it, that should also work
Bump CAPI providers version
bump caprke2 provider
1 file(s) updated with "https://github.com/rancher/cluster-api-provider-rke2/releases/v0.7.1/": * ./internal/controllers/clusterctl/config.yaml
v0.7.1
bump capz provider
1 file(s) updated with "https://github.com/rancher-sandbox/cluster-api-provider-azure/releases/v1.17.0/": * ./internal/controllers/clusterctl/config.yaml
v1.17.0
bump capv provider
1 file(s) updated with "https://github.com/rancher-sandbox/cluster-api-provider-vsphere/releases/v1.11.2/": * ./internal/controllers/clusterctl/config.yaml
v1.11.2
bump core capi
1 file(s) updated with "https://github.com/rancher-sandbox/cluster-api/releases/v1.8.4/": * ./internal/controllers/clusterctl/config.yaml
v1.8.4
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!