Reintroduce recipeBook crafting #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on this ? masa is looking to release to CF. |
wendavid552
force-pushed
the
pre-rewrite/fabric/1.21-recipebook-crafting
branch
from
d04c3bd to
bdec4bb
Compare
wendavid552
force-pushed
the
pre-rewrite/fabric/1.21-recipebook-crafting
branch
2 times, most recently
from
e9f30fc to
651b66a
Compare
|
sakura-ryoko
merged commit 38d3015
into
sakura-ryoko:pre-rewrite/fabric/1.21
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the code from @zly2006 (code originally in #4 , and idea from Andrew's craftfix fork) which is not actually using recipe books for crafting (the vanilla recipe manager is not ready when just after connecting to the client, it sync the recipe information after receiving packets).
This crafting method is much stable than swapOnly and the old method, it make much fewer mistakes in crafting.