From eed2b5c8fb58d9e07b060b614abfc061e26faade Mon Sep 17 00:00:00 2001
From: David Llewellyn-Jones <david.llewellyn-jones@jolla.com>
Date: Mon, 7 Mar 2022 17:25:50 +0200
Subject: [PATCH] [qtmozembed] Avoid sending orientation signal on scene
 changes. Fixes JB#57688

Emitting an orientationChange signal when the QuickMozView is added to a
scene can cause a segmentation fault, because the QML engine isn't ready
to be activated.

This change ensures the orientation is set correctly, but without
emitting the signal.
---
 src/quickmozview.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/quickmozview.cpp b/src/quickmozview.cpp
index df9419f..9ad153f 100644
--- a/src/quickmozview.cpp
+++ b/src/quickmozview.cpp
@@ -145,7 +145,12 @@ void QuickMozView::itemChange(ItemChange change, const ItemChangeData &data)
         if (data.window) {
             connect(data.window, &QQuickWindow::contentOrientationChanged, this, &QuickMozView::updateOrientation);
 
+            // Update the orientation, but without emitting an orientationChanged signal
+            // Emitting the signal at this point will cause a SIGSEGV because
+            // the QML item isn't ready to be activated just yet, see JB#57688
+            blockSignals(true);
             updateOrientation(data.window->contentOrientation());
+            blockSignals(false);
         }
     }
     QQuickItem::itemChange(change, data);