Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Override handleContentTap function #200

Open
MaorS opened this issue Jan 4, 2019 · 0 comments · May be fixed by #216
Open

Cannot Override handleContentTap function #200

MaorS opened this issue Jan 4, 2019 · 0 comments · May be fixed by #216
Labels
bug

Comments

@MaorS
Copy link

MaorS commented Jan 4, 2019

Report

What did you do?

Subclass MPMoviePlayerViewController and trying to override handleContentTap function
as recommended
screen shot 2019-01-04 at 22 19 02

What did you expect to happen?

To be able to override handleContentTap function

What happened instead?

Overriding non-open instance method outside of its defining module
screen shot 2019-01-04 at 22 16 03

Please replace public keyword with open
@isair isair added the bug label Apr 26, 2019
@ageofadz ageofadz linked a pull request May 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open access for handleContentTap() ageofadz/mobileplayer-ios
2 participants
@isair @MaorS