Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation of Report a Person page, shows incorrect message #54

Open
Chanaka opened this issue Mar 3, 2014 · 9 comments
Open

Comments

@Chanaka
Copy link
Contributor

Chanaka commented Mar 3, 2014

  1. Navigate to Report a Person page.
  2. Select french language.
  3. Page shows the message "Vous pouvez effectuer une recherche href="search"> avant de reporting. Dans le cas contraire ...".

The french message contains additional part "href="search">" which is a part of html codes. This html related part should not be displayed in the message.

@praful94
Copy link
Contributor

  1. I went to http://localhost/vesuvius/vesuvius/www/test/report
  2. I didn't find any option for "select" language, so I translated to "french" using google translate, but I didn't find any mistake as stated above.
  3. Can you describe a little bit more about the above stated problem?

@ramdesh
Copy link
Member

ramdesh commented Mar 13, 2014

You need to enable locale first in sahana.conf. This will give you a dropdown to change the locale.

@Chanaka
Copy link
Contributor Author

Chanaka commented Mar 13, 2014

Make $conf['enable_locale'] = true; in sahana.conf file. Default value is false https://github.com/sahana/vesuvius/blob/master/vesuvius/conf/sahana.conf.example#L50

@praful94
Copy link
Contributor

In the file /vesuvius/vesuvius/mod/report/main.inc, on this particular line
"_t('ReportAPerson-QuickSearch-Link|You may wish to perform a quick search before reporting. Otherwise...') "
If I change anything in the string passed to _t function, then it doesn't get translated to french or any other language. e.g. If I omit the word "perform" from the passed string, the whole string don't get translated to any other language. Please, can you explain this?

I tried to understand the whole "translation" process, but after _gettext() function in "/vesuvius/vesuvius/inc/lib_locale/gettext.inc" file, I am not able to understand the translation process as why omitting a word results in "non translating" behaviour.

@praful94
Copy link
Contributor

Fixed the issue.

@ramdesh
Copy link
Member

ramdesh commented Mar 14, 2014

@praful94, to respond to your earlier query, the translation framework takes exact strings as they are and translates them. If you change a string, you need to regenerate the sahana.pot file and then propagate the change to each *.po file via Pootle, which is our translation platform.

@ramdesh
Copy link
Member

ramdesh commented Mar 14, 2014

@Chanaka this is not an issue related specifically to the French translation. It is related to how the sahana.pot file is generated and the actual string which has been placed within the _t() function.

@praful94
Copy link
Contributor

yeah, I understood that by looking at .po and .pog files, that's why I changed hyperlinks(anchor tags) in fr_g.pog and ja_g.pog and then compiled fr_g.mo and ja_g.mo for changes to take effect.

@vidurangaw
Copy link
Contributor

Hi,
I have fixed the issue. Can you check if it's correct
#58
Thanks

ramdesh added a commit that referenced this issue Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants