-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the build in travis deployment mechanism to deploy to GitHub pages. #23
Comments
@mkoeppe Since you implemented the original mechanism I have a question for you: Am I correct in assuming that you implemented it this way because you didn't know about the built in deployment mechanism of travis yet (because it possibly didn't even exist yet then)? |
Ok, I looked a bit more into this. And it seems that the build in mechanism wants to have a GitHub authentication token that gives write acces to all your GitHub repositories!!! This looks nonsensical and insanely insecure to me. |
Yes, I think it is relatively new. And yes, I much prefer the method using ssh keys that I used, which gives more fine-grained access. (Just a few months ago there was a notice about a huge security hole involving the GitHub authentification token; at that time I was glad I didn't go that way.) |
By the way, from looking at it at https://github.com/travis-ci/dpl/blob/master/lib/dpl/provider/pages.rb it seems that the reason it needs the authentification token is just because it uses git over https by default. If someone reading this here knows ruby then we could submit a pull request that just uses git over ssh if the token is not provided. But let's keep that for the future. For the time being I have been playing around with travis a bit to get to understand how it works. And it does seem that there are two enhancements that I want to make to the current ssh key based setup in sage_sample.
|
I agree with 1. and 2. |
In #8 the possibility to make the documentation visible on GitHub pages was added, however this was done using custom bash scripts. Travis also has a build in mechanism for deploying documentation to GitHub pages. This seems much cleaner and removes the need of deployment keys.
The text was updated successfully, but these errors were encountered: