Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky simplicial set test #38940

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix flaky simplicial set test #38940

wants to merge 2 commits into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Nov 8, 2024 •
edited
Loading

Fixes #38888 .

This test has been failing sporadically recently e.g. https://github.com/sagemath/sage/actions/runs/11733902583/job/32689016794?pr=38938 .

From my understanding of simplicial set, the two sigma_1 are actually representing two different cells (the wedge looks like a "8" shape), but because they both come from S1 (the 1-sphere i.e. circle), they get the same name.

SageMath does some magic during doctest so that dict entries are sorted, but the problem is

        At this point, comparison between v and w is random, based on
        their location in memory. ::

so with some chance it fails.

This change should make it deterministic --- since the two faces are named sigma_1 and sigma_1', the comparison should be by custom name…?

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes. (not applicable)
  • I have updated the documentation and checked the documentation preview.

@user202729 user202729 mentioned this pull request Nov 8, 2024
Open
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f070aa3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

The failed test is

2024-11-08T15:09:09.5768206Z **********************************************************************
2024-11-08T15:09:09.5893109Z File "src/sage/groups/finitely_presented_named.py", line 489, in sage.groups.finitely_presented_named.AlternatingPresentation
2024-11-08T15:09:09.5894783Z Failed example:
2024-11-08T15:09:09.5895452Z     A1.is_isomorphic(A2), A1.order()
2024-11-08T15:09:09.5896032Z Expected:
2024-11-08T15:09:09.5896389Z     (True, 1)
2024-11-08T15:09:09.5896732Z Got:
2024-11-08T15:09:09.5897089Z     #I  Forcing finiteness test
2024-11-08T15:09:09.5897589Z     (True, 1)
2024-11-08T15:09:11.2068744Z **********************************************************************

This is obviously #38889 instead.

By the way, GitHub Actions doesn't seem to be able to report test failure to the GitHub interface?

@user202729 user202729 mentioned this pull request Nov 8, 2024
Open
5 tasks
@orlitzky
Copy link
Contributor

This is obviously #38889 instead.

Potential solution: #38956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random test failure in simplicial_sets
2 participants
@user202729 @orlitzky