external Pari 2.17 does not work (yet) #38769
Comments
|
Related: #38749 (upgrade pari to 2.17). It's not clear to me how close that is to being ready, though. |
The sagelib part is mostly ready (I just need to push some fixes for test failures caused by different ideal and unit group generators). However, that's just a small part of the story: most of the breakage is in cypari, which would need a new release including sagemath/cypari2#165 and sagemath/cypari2#166. And, to make things worse, 2.17.0 ships with a bug that breaks cypari build. So 2.17.0 should probably be unconditionally disallowed, and once 2.17.1 is released we should upgrade pari and cypari in sage. |
Not surprisingly, this works well, fixes the problem for me. I've opened a PR that makes this change. |
Do not allow external Pari 2.17 or later <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Sage does not build with Pari 2.17. Homebrew distributes this verison, so we disallow it. This fixes sagemath#38769. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38772 Reported by: John H. Palmieri Reviewer(s): Dima Pasechnik
Do not allow external Pari 2.17 or later <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Sage does not build with Pari 2.17. Homebrew distributes this verison, so we disallow it. This fixes sagemath#38769. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38772 Reported by: John H. Palmieri Reviewer(s): Dima Pasechnik
Steps To Reproduce
If Pari 2.17 is installed system-wide, it could be picked up, but doesn't work.
Expected Behavior
Sage should not use Pari 2.17
Actual Behavior
it does
Additional Information
it's a 1-line fix in pari's spkg-configure.m4$\geq 135424$
Ban versions
Environment
Checklist
The text was updated successfully, but these errors were encountered: