Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement loos coupling to 3rd party module #1

Open
safhac opened this issue Oct 5, 2021 · 0 comments
Open

implement loos coupling to 3rd party module #1

safhac opened this issue Oct 5, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@safhac
Copy link
Owner

safhac commented Oct 5, 2021

the current CompositionRenderer is tightly coupled to moviepy, the render method returns a moviepy CompositeVideoClip

class CompositionRenderer:
   ...
   async def render((self, composition: CompositionSpec) -> CompositeVideoClip:

fix the design flaw by implementing a loosely coupled dependency to allow other frameworks e.g ffmpeg-python
@safhac safhac added bug Something isn't working enhancement New feature or request labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@safhac