Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about function loadSystemRoots #100

Open
lysShub opened this issue Oct 1, 2024 · 3 comments
Open

about function loadSystemRoots #100

lysShub opened this issue Oct 1, 2024 · 3 comments

Comments

@lysShub
Copy link

lysShub commented Oct 1, 2024

  1. if !strings.Contains(string(out), "command completed successfully") { not work on other language system;maybe if cmd.ProcessState.ExitCode() != 0 {
@lysShub
Copy link
Author

lysShub commented Oct 1, 2024

  1. certutil -syncWithWU cost too many time, recommend use certutil -verify directly

@LordNoteworthy
Copy link
Member

@lysShub thanks for your feedback.

I agree we should check exit code regarding point number 1.
For point 2: do you know if verify does grab the lastest certs ?

@lysShub
Copy link
Author

lysShub commented Oct 7, 2024

@lysShub thanks for your feedback.

I agree we should check exit code regarding point number 1. For point 2: do you know if verify does grab the lastest certs ?

my test result is, when a required cert missing:
    if exec 'certutil verify xxx.crt' with administrator access, the system will automatically download the missing cert
    otherwise, will verify fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants