feat: add Linea Goerli Testnet #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvisKrop
requested review from
Uxio0,
moisses89 and
akshay-ap
and removed request for
a team
moisses89
reviewed
Jun 14, 2023
gnosis/eth/ethereum_network.py
Outdated
| @@ -557,6 +557,7 @@ class EthereumNetwork(Enum): | |||
| REI_CHAIN_MAINNET = 55555 | |||
| REI_CHAIN_TESTNET = 55556 | |||
| BOBA_BNB_MAINNET = 56288 | |||
| LINEA_GOERLI_TESTNET = 59140 | |||
There was a problem hiding this comment.
We are using the ethereum-list name https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-59140.json#LL2C12-L2C25 could you rename it to LINEA_TESTNET?
There was a problem hiding this comment.
@moisses89 ✔️ done at aab610f
|
Happy Monday! @moisses89 |
moisses89
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add Linea Goerli Testnet:
safe-global/safe-deployments#230
Thank you.