Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retrieve Viem info script and update multicall addresses #1376

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix retrieve Viem info script and update multicall addresses #1376

merged 1 commit into from
Oct 10, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

No description provided.

@falvaradorodriguez falvaradorodriguez self-assigned this Oct 10, 2024
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner October 10, 2024 11:16
@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11272931260

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.008%) to 93.561%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/clients/ens_client.py 1 59.38%
safe_eth/safe/tests/utils.py 1 60.0%
safe_eth/eth/ethereum_client.py 1 85.67%
safe_eth/safe/safe_tx.py 1 90.97%
Totals Coverage Status
Change from base Build 11254978185: 0.008%
Covered Lines: 8805
Relevant Lines: 9411
💛 - Coveralls

moisses89
moisses89 approved these changes Oct 10, 2024
View reviewed changes
safe_eth/eth/tests/test_multicall.py
def test_addresses_are_checksum_address(self):
addresses = Multicall.ADDRESSES
for _, address in addresses.items():
self.assertTrue(fast_is_checksum_address(address))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@falvaradorodriguez falvaradorodriguez merged commit 94a6c78 into main Oct 10, 2024
7 checks passed
@falvaradorodriguez falvaradorodriguez deleted the fix-info-from-viem-script branch October 10, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees

@falvaradorodriguez falvaradorodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falvaradorodriguez @coveralls @moisses89